Re: [PATCH] bundle: remove ignored & undocumented "--verbose" flag

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Sep 23, 2021 at 06:48:22PM +0200, Ævar Arnfjörð Bjarmason wrote:
> In 73c3253d75e (bundle: framework for options before bundle file,
> 2019-11-10) the "git bundle" command was refactored to use
> parse_options(). In that refactoring it started understanding the
> "--verbose" flag before the subcommand, e.g.:
>
>     git bundle --verbose verify --quiet
>
> However, nothing ever did anything with this "verbose" variable, and
> the change wasn't documented. It appears to have been something that
> escaped the lab, and wasn't flagged by reviewers at the time. Let's
> just remove it.

Thanks; this looks good to me. We never use the `verbose` variable for
anything, and it isn't documented. So I agree that it can be removed.

Thanks for cleaning this up:

    Reviewed-by: Taylor Blau <me@xxxxxxxxxxxx>

Thanks,
Taylor



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux