On Wed, Sep 22, 2021 at 03:16:22PM -0400, Derrick Stolee wrote: > On 9/21/2021 4:45 PM, Taylor Blau wrote: > [...] > > I fear that we're talking about different things. With your patches, if > > I munge my .git/info/sparse-checkout file, I can easily get something > > like: > > > > $ git.compile sparse-checkout list > > warning: unrecognized pattern: 'foo' > > warning: disabling cone pattern matching > > > > to appear. But I'm wondering why the same doesn't happen when running > > `git sparse-checkout init --cone` while the existing sparse-checkout > > definition contains non-cone mode entries. > > You don't get that warning because it's not trying to parse the > previous patterns using cone mode. Before my series, you would get > the warning in a _second_ run of "git sparse-checkout init --cone". OK. I was confused because in [1] you said that we produce this error any time we try to load the existing definitions and parse them in cone-mode. I would have assumed that we would try to do that during `init --cone` to read the existing sparse-checkout definition. Thanks, Taylor [1]: https://lore.kernel.org/git/734ecf93-e563-20d5-7cf1-74048aa74d56@xxxxxxxxx/
