On 9/21/2021 9:12 AM, Ævar Arnfjörð Bjarmason wrote: > A hopefully final re-roll addressing Taylor's v3 review, except for > the suggestion (that I read as) perhaps retaining the test-only code, > which I've decided not to do per > http://lore.kernel.org/git/87tuieakms.fsf@xxxxxxxxxxxxxxxxxxx > > The x(un)setenv() now returns void, and the error messages are less > chatty, I also improved a BUG() message in 4/5 that we end up deleting > in 5/5 anyway, so it doesn't matter for the end-state, just for > understanding the patches. > > Ævar Arnfjörð Bjarmason (5): > wrapper.c: add x{un,}setenv(), and use xsetenv() in environment.c > environment.c: remove test-specific "ignore_untracked..." variable > read-cache & fetch-negotiator: check "enum" values in switch() > repo-settings.c: simplify the setup > repository.h: don't use a mix of int and bitfields This version looks good to me. Thanks, -Stolee
