> - strbuf_addf(&fmt, "%%s%%s%%s-%%0%1$lud.%%0%1$lud-%%s-%%s-%%s", > - (unsigned long)tmp.len); > + strbuf_addf(&fmt, "%%s%%s%%s-%%0%lud.%%0%lud-%%s-%%s-%%s", > + (unsigned long)tmp.len, (unsigned long)tmp.len); The C standard version seems simpler to me, so I would say this was a good outcome overall. > I may be wrong, but I believe that construct is widely portable, we > don't use it in the main source, but in the po/ files (so anything that > uses git + gettext tests for this already): > > git grep -P '%\d+\$' -- po It is not part of ANY C standard, so it will just print gibberish in systems that don't carry this extension. FWIW is not supported in Windows, which probably explains why they don't carry the po files. Carlo
