On Mon, Sep 20, 2021 at 9:09 PM Jeff King <peff@xxxxxxxx> wrote: > @@ -971,7 +966,7 @@ static int match_one_pattern(struct grep_pat *p, char *bol, char *eol, > switch (p->field) { > case GREP_HEADER_AUTHOR: > case GREP_HEADER_COMMITTER: > - saved_ch = strip_timestamp(bol, &eol); > + strip_timestamp(bol, &eol); Why not something like (plus added error handling, even if it seems the original didn't have them)? eol = strrchr(bol, '>'); Carlo