On 9/19/2021 4:47 AM, Ævar Arnfjörð Bjarmason wrote: > Simplify the setup code in repo-settings.c in various ways, making the > code shorter, easier to read, and requiring fewer hacks to do the same > thing as it did before: Popping in here to say that I agree this new arrangement is cleaner. The previous patterns were confusing, and probably led to at least one bug, including one in the builtin FS Monitor shipped with git-for-windows/git [1] where enabling features.experimental overrides core.useBuiltinFSMonitor=false. The newer organization should make it harder for mistakes like that to happen. Thanks, -Stolee [1] https://github.com/git-for-windows/git/discussions/3251#discussioncomment-1296896
