Because pretty_print_ref() currently has no ref_item flag, but the implementation of %(symref) need this flag, so git tag --verify or git verify-tag cannot get the output of %(symref). Therefore, %(symref) will be fixed in this patch series. This bug was discovered by Peff here: https://lore.kernel.org/git/YUO63qy2%2F5wibY4%2F@xxxxxxxxxxxxxxxxxxxxxxx/ on the other hand, git tag --verify --format="%(refname)" or git verify-tag --forrmat="%(refname)" does not show the fullref name, but seems to be similar to using %(refname:lstrip=2). And git verify-tag --format="verify: %(refname)" c06b72d02` will output: "verify: c06b72d02". They are wrong features, but because some scripts are using them, so our current approach is to keep them. ZheNing Hu (4): refs: let repo_dwim_ref() learn get symref itself and ref flags ref-filter: provide ref_flags to pretty_print_ref() verify_tag: use repo_dwim_ref() to get ref fullname and ref_flags ref-filter: let tag verify use %(refname:lstrip=2) by default builtin/tag.c | 16 ++++++++------- builtin/verify-tag.c | 9 ++++++++- object-name.c | 6 +++--- ref-filter.c | 47 +++++++++++++++++++++++++++++++++---------- ref-filter.h | 4 +++- refs.c | 15 +++++++++----- refs.h | 8 +++++--- t/t7030-verify-tag.sh | 23 +++++++++++++++++++++ upload-pack.c | 2 +- 9 files changed, 98 insertions(+), 32 deletions(-) base-commit: 8b7c11b8668b4e774f81a9f0b4c30144b818f1d1 Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1042%2Fadlternative%2Fpretty-print-ref-symref-fix-v1 Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1042/adlternative/pretty-print-ref-symref-fix-v1 Pull-Request: https://github.com/gitgitgadget/git/pull/1042 -- gitgitgadget
