Re: [PATCH v2 5/7] p5326: don't set core.multiPackIndex unnecessarily

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Sep 14, 2021 at 06:06:11PM -0400, Taylor Blau wrote:

> When this performance test was originally written, `core.multiPackIndex`
> was not the default and thus had to be enabled. But now that we have
> 18e449f86b (midx: enable core.multiPackIndex by default, 2020-09-25), we
> no longer need this.
> 
> Drop the unnecessary setup (even though it's not hurting anything, it is
> unnecessary at best and confusing at worst).

Makes sense. Sometimes it is worthwhile to carry extra code in the perf
tests for older versions, so that we can test performance across a wider
span. But there were no midx bitmaps at all when 18e449f86b happened, so
there is little point in worrying about going back that far for this
test.

-Peff



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux