On Tue, Sep 07, 2021 at 12:58:08PM +0200, Ævar Arnfjörð Bjarmason wrote: > This minor formatting change serves to make a subsequent patch easier > to read. Hmm. I'm not sure if I agree. As far as I can tell from reading the subsequent patch, this is designed to make it easier to add a comment above "return type" that pertains just to the case when !*hdr. I think it would have been fine to go from the ternary to this style with the comment in a single patch. But I also think it would have been fine to add the comment above the ternary and instead start it off by saying "when !*hdr, ...". Thanks, Taylor