On Tue, Sep 07, 2021 at 12:58:05PM +0200, Ævar Arnfjörð Bjarmason wrote: > Make the parse_loose_header_extended() function public and remove the > parse_loose_header() wrapper. The only direct user of it outside of > object-file.c itself was in streaming.c, that caller can simply pass > the required "struct object-info *" instead. > > This change is being done in preparation for teaching > read_loose_object() to accept a flag to pass to > parse_loose_header(). It isn't strictly necessary for that change, we > could simply use parse_loose_header_extended() there, but will leave > the API in a better end state. All seems reasonable. I agree that this is not a necessary step, but at least the clean-up is self contained and an easy enough read. The flag that read_loose_object() is going to start passing to parse_loose_header() is left a bit vague, but I'll continue reading to figure out what it is. Thanks, Taylor
