On Tue, Sep 07, 2021 at 12:58:03PM +0200, Ævar Arnfjörð Bjarmason wrote: > When the loose_object_info() function returns an error stop faking up > the "oi->typep" to OBJ_BAD. Let the return value of the function > itself suffice. This code cleanup simplifies subsequent changes. The obvious danger (which you mention) is that somebody is relying on what typep points to, and is reading it even if we returned non-zero from whatever called this function. Hopefully nobody is, but this change makes me a little uncomfortable nonetheless, since there are so many potential callers (even though this function has only one caller, it doesn't take long before the number of indirect callers explodes). So it would be nice if we could do without it, but you claim that it simplifies changes that happen later on. So let's continue to see if we really do need it... Thanks, Taylor
