On Wed, Sep 15, 2021 at 11:23:28PM -0700, Junio C Hamano wrote: > Taylor Blau <me@xxxxxxxxxxxx> writes: > > >> + tree=$(cat out | sed -n -e "s/^tree //p" -e "/^author /q") && > > > > In this and the below tests which had a similar transformation, the > > first invocation does not mask its error, since it's on the right-hand > > side of a pipe. > > > > But piping "git show" to sed will mask the exit code of the former. So > > that makes sense. But I would like to see us avoid an unnecessary > > cat-into-pipe and instead redirect out into sed, like "sed -n -e ... > > <out". > > [...] or for commands like "sed" that takes its input from files > listed on the command line, you should be able to write it without the > input "<" redirection. Even better, thanks for noticing the flaw in my suggestion. Thanks, Taylor
