On 16/09/21 16.50, Ævar Arnfjörð Bjarmason wrote:
...this really is not an INSTALL_STRIP but (using some combination of your own naming) a "INSTALL_XPROGRAMS_OPTS" or "INSTALL_XOPTS". I.e. you can supply arbitrary options to "install" with this, but only for binaries.
I think it should have been "INSTALL_STRIP_OPTS". This could haven't been issue if we add global (applicable tobinaries and scripts) "INSTALL_OPTS".
Also doesn't this misbehave under MSVC when combined with *.pdb files? See dce7d295514 (msvc: support building Git using MS Visual C++, 2019-06-25) and a8b5355d808 (msvc: copy the correct `.pdb` files in the Makefile target `install`, 2020-09-21) , i.e. the code at the start of your diff context. Does stripping the main binary while having a *.pdb file error or MSCV, or make the *.pdb file useless, or is *.pdb an unconditional equivalent of INSTALL_STRIP=-s on MSCV that we should disable if this hopefully-then-boolean INSTALL_STRIP option is enabled?
I'm not familiar with MSVC, so I can't tell further except you can pass null ("") to INSTALL_STRIP.
-- An old man doll... just what I always wanted! - Clara
