On Wed, Sep 15 2021, Jeff Hostetler via GitGitGadget wrote: > From: Jeff Hostetler <jeffhost@xxxxxxxxxxxxx> > > Do not leak the thread name (contained within the thread context) when > a thread terminates. > > Signed-off-by: Jeff Hostetler <jeffhost@xxxxxxxxxxxxx> > --- > trace2/tr2_tls.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/trace2/tr2_tls.c b/trace2/tr2_tls.c > index 067c23755fb..7da94aba522 100644 > --- a/trace2/tr2_tls.c > +++ b/trace2/tr2_tls.c > @@ -95,6 +95,7 @@ void tr2tls_unset_self(void) > > pthread_setspecific(tr2tls_key, NULL); > > + strbuf_release(&ctx->thread_name); > free(ctx->array_us_start); > free(ctx); > } As noted in your cover letter: * A fix for a memory leak in the Trace2 code. (This was independently reported in last week in "ab/tr2-leaks-and-fixes".) So I think this patch can be dropped from this series, since it's exact duplicate of my 48f68715b14 (tr2: stop leaking "thread_name" memory, 2021-08-27) in ab/tr2-leaks-and-fixes, currently in "next" and marked for a merge with master. When submitting a series that depends on another one it's best to rebase it on top of it & indicate it as such in the cover letter, Junio can queue such a series on top of another one. In this case I'm still not sure why this fix is here, i.e. surely nothing later in the series absolutely needs this stray memory leak fix...
