On Thu, Sep 16, 2021 at 12:53:07AM -0400, Taylor Blau wrote: > > +/** > > + * Callback used by `start_bg_command()` to ask whether the > > + * child process is ready or needs more time to become ready. > > + * > > + * Returns 1 is child needs more time (subject to the requested timeout). > > + * Returns 0 if child is ready. > > + * Returns -1 on any error and cause `start_bg_command()` to also error out. > > + */ > > +typedef int(start_bg_wait_cb)(void *cb_data, > > + const struct child_process *cmd); > > Nitpicking, but typically I would assume that the "extra" void pointer > is the last argument in a callback. It definitely does not matter, > though. Looking at the last patch (which adds the first implementation of one of these callbacks) it appears that this cb_data pointer is unused. I assume that it is used in later patches which aren't in this topic? If so, then it may help future readers to indicate as much in the patch message. Perhaps "the cb_data argument in the start_bg_wait_cb callback is unused in this series, but will be useful in later patches". Thanks, Taylor
