Re: [PATCH] git-clone: better error message if curl program is missing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Sep 07, 2007 at 02:19:32PM -0700, Junio C Hamano wrote:
> Gerrit Pape <pape@xxxxxxxxxxx> writes:
> In other words, instead of this:
> 
> >  http_fetch () {
> >  	# $1 = Remote, $2 = Local
> > +	type curl >/dev/null 2>&1 ||
> > +	    die "The curl program is not available"
> >  	curl -nsfL $curl_extra_args "$1" >"$2"
> >  }
> 
> something like this, perhaps:
> 
> 	http_fetch () {
>         	# $1 = remote, $2 = local
>                	curl -nsfL $curl_extra_args "$1" >"$2" || exit
> 	}
> 
> Then the shell would say "curl: command not found" and we would
> stop.

Yes, just fine.

> BTW, isn't it a packaging bug not to depend git-fetch on curl?

There're different types of package relationships in Debian,
'Depends' is an absolute dependency, meaning that another package is
required for this package to provide a significant amount of
functionality.  Then there's 'Recommends', a strong but not absolute
dependency, meaning that another package is required in all but unusual
installations.  Debian's package management tools normally install all
'Recommends' automatically, just as 'Depends'.

The curl program is only needed when using the http transport, so it
falls into the 'Recommends' category.

An installation of git without the curl program also installed is very
unusual, but supported in Debian.

Regards, Gerrit.
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux