Hi Carlo, On Mon, 13 Sep 2021, Carlo Marcelo Arenas Belón wrote: > Eventhough NO_UNIX_SOCKETS was specifically added to support Windows, > it might not be necessary in the future, because Windows added support > for Unix Sockets in late 2017. The fact that some recent Windows 10 versions support Unix sockets is nice, no doubt. As far as Git for Windows is concerned (which does not recompile itself during an installation based on the Windows version it found), we cannot use it, of course. At least not until all of the previous Windows versions are _long_ out of service. For example, we still support Windows 7 even if it reached it's "End-Of-Life". Having said that: thank you for working on this. For users who build their Git themselves (which is definitely something Git for Windows makes easy), the option to use Unix sockets is really nice. Ciao, Dscho > The implementation of Unix Sockets, uses an internal NTFS mechanism > and is therefore not visible at the filesystem layer, like it is in > UNIX, but seems to be good enough to allow to build and run the > `git credential-cache` and its daemon; additional testing to confirm > trace2 (builds and doesn't fail any tests) is functional will be > needed. > > V2 reuses the same third patch from V1, and applies all suggested > feedback on patches 1 and 2 and should apply cleanly as a reroll of > cb/unix-sockets-with-windows. > > Carlo Marcelo Arenas Belón (3): > t0301: fixes for windows compatibility > credential-cache: check for windows specific errors > git-compat-util: include declaration for unix sockets > > builtin/credential-cache.c | 30 ++++++++++++++++++++++++++++-- > git-compat-util.h | 3 +++ > t/t0301-credential-cache.sh | 32 ++++++++++++++++++++++++-------- > 3 files changed, 55 insertions(+), 10 deletions(-) > > -- > 2.33.0.481.g26d3bed244 > >
