On Thu, Sep 9, 2021 at 10:32 PM Junio C Hamano <gitster@xxxxxxxxx> wrote: > > "Han-Wen Nienhuys via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes: > > > The reftable format is described in Documentation/technical/reftable.txt. > > > > This is a fully reentrant implementation of reading and writing the reftable > > file format, and should be suitable for embedding in libgit2 too. It does > > not hook the code up to git to function as a ref storage backend yet. > > Not a question for Han-Wen, but I am wondering how much style and > other consistency guidelines we have in our C code to the files in > this directory. I am Han-Wen, but I'm not sure what you are saying here. > I am guessing that rules like "no decl after statement" and "no decl > in the set-up part of the for loop control" (i.e. "for (int i = 0; > ..." is a no-no) should apply equally to this code, but it might be > OK to deviate from rules that are only meant to help human readers [*] > without affecting compilation. > > Opinions? The code has a different style because I wrote it separately from Git. I'm not wedded to its current style, and most styling can easily be changed. If you have specific things that should be addressed, let me know. -- Han-Wen Nienhuys - Google Munich I work 80%. Don't expect answers from me on Fridays. -- Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Paul Manicle, Halimah DeLaine Prado
