On Sat, Sep 11 2021, Carlo Arenas wrote:
> On Sat, Sep 11, 2021 at 5:16 PM Ævar Arnfjörð Bjarmason
> <avarab@xxxxxxxxx> wrote:
>>
>> We'll be changing the "int nr" in the "struct strvec" to "int size_t"
>
> Did you mean "size_t nr"?
Yes, will fix.
>> -static int push_git(struct discovery *heads, int nr_spec, const char **specs)
>> +static int push_git(struct discovery *heads, struct strvec *specs)
>> {
>> struct rpc_state rpc;
>> - int i, err;
>> + int i;
>
> you are already splitting them, why not then change 'i' also to be a size_t?
The conversion to size_t comes later in this series, this is setting
that diff up to be smaller. I.e. we'll then to s/int i/size_t /g.
