Re: [PATCH 6/6] Replace all read_fd use with strbuf_read, and get rid of it.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Pierre Habouzit <madcoder@xxxxxxxxxx> writes:

>   This brings builtin-stripspace, builtin-tag and mktag to use strbufs.

One worry I have about this is that strbuf_read() only does the
default allocation growth, while all of these callers used to
have some guess as to what the initial allocation to avoid
realloc should be.

Perhaps you would want to pre-grow the buffer between strbuf_init()
and strbuf_read() calls?

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux