On Fri, Sep 10, 2021 at 01:04:28PM +0200, Ævar Arnfjörð Bjarmason wrote:
> In 1119a15b5c8 (http: drop support for curl < 7.11.1, 2021-07-30)
> support for curl versions older than 7.11.1 was removed, and we
> currently require at least version 7.19.4, see 644de29e220 (http: drop
> support for curl < 7.19.4, 2021-07-30).
>
> In those changes this Makefile-specific check added in
> 0890098780f (Decide whether to build http-push in the Makefile,
> 2005-11-18) was missed, now that we're never going to use such an
> ancient curl version we don't need to check that we have at least
> 7.9.8 here. I have no idea what in http-push.c broke on versions older
> than that.
Nice catch. I was curious, and I think the issue was just that older
versions did not have the curl_multi_* interface.
> @@ -1436,15 +1436,8 @@ else
> REMOTE_CURL_NAMES = $(REMOTE_CURL_PRIMARY) $(REMOTE_CURL_ALIASES)
> PROGRAM_OBJS += http-fetch.o
> PROGRAMS += $(REMOTE_CURL_NAMES)
> - curl_check := $(shell (echo 070908; $(CURL_CONFIG) --vernum | sed -e '/^70[BC]/s/^/0/') 2>/dev/null | sort -r | sed -ne 2p)
> - ifeq "$(curl_check)" "070908"
> - ifndef NO_EXPAT
> - PROGRAM_OBJS += http-push.o
> - else
> - EXCLUDED_PROGRAMS += git-http-push
> - endif
> - else
> - EXCLUDED_PROGRAMS += git-http-push
> + ifndef NO_EXPAT
> + PROGRAM_OBJS += http-push.o
> endif
I wonder if this $(CURL_CONFIG) check could have been be problematic for
some obscure platforms, if they set up CURL_{CFLAGS,LDFLAGS,LIBCURL}
manually (rather than relying on curl-config). We do have one more
similar check:
> curl_check := $(shell (echo 072200; $(CURL_CONFIG) --vernum | sed -e '/^70[BC]/s/^/0/') 2>/dev/null | sort -r | sed -ne 2p)
...and nobody has complained either way, so perhaps it doesn't matter
much. Anyway, I'm happy to see this now-useless code go away. :)
-Peff
