Re: [PATCH 03/11] t3407: use test_cmp_rev

Phillip Wood <phillip.wood123@xxxxxxxxx> · Wed, 8 Sep 2021 14:42:04 +0100




On 08/09/2021 11:40, Ævar Arnfjörð Bjarmason wrote:

On Wed, Sep 08 2021, Phillip Wood via GitGitGadget wrote:

@@ -54,9 +54,9 @@ testrebase() {
  		echo d >> a &&
  		git add a &&
  		test_must_fail git rebase --continue &&
-		test $(git rev-parse HEAD) != $(git rev-parse main) &&
+		! test_cmp_rev HEAD main &&

Use "test_cmp_rev !", making the shell do the negation is troublesome
for the same reason we don't do it with git command, it potentially
hides segfaults (and that test helper invokes "git", hence the optional
"!" first argument).

Thanks, I didn't realize one could pass "!" to test_cmp_rev - it gives a 
better message on failure as well as avoiding hidden segfaults

Best Wishes

Phillip







