On Tue, Sep 07, 2021 at 03:10:22PM -0700, Junio C Hamano wrote: > Back when a1be47e4 (hash-object: fix buffer reuse with --path in a > subdirectory, 2017-03-20) was written, the prefix_filename() helper > used a static piece of memory to the caller, making the caller > responsible for copying it, if it wants to keep it across another > call to the same function. Two callers of the prefix_filename() in > hash-object were made to xstrdup() the value obtained from it. > > But in the same series, when e4da43b1 (prefix_filename: return newly > allocated string, 2017-03-20) changed the rule to gave the caller > possession of the memory, we forgot to revert one of the xstrdup() > changes, allowing the returned value to leak. Good catch. The patch looks obviously correct to me. -Peff
