On Tue, Sep 07, 2021 at 10:50:58PM -0400, Taylor Blau wrote: > Of the two, I think the former is more appealing (since no other > functions called by finish_tmp_packfile() are guarded like that; they > conditionally behave as noops depending on `flags`). Sorry; this is nonsensical. The only other function we call is write_idx_file() which merely changes its behavior based on flags, but it never behaves as a noop. That doesn't change my thinking about preferring the former of my two suggestions, but just wanted to correct my error. Thanks, Taylor
