On Tue, Sep 07, 2021 at 05:33:28PM +0200, Ævar Arnfjörð Bjarmason wrote: > Changes since v3: > > * Much updated commit message > > * Re-arranged the t/README change to avoid a conflict with "seen". > > * Now testing OSX as well as Linux. Full CI passes on top of "master" > on both: https://github.com/avar/git/runs/3535331215 > > * I ejected the previous 4-8/8 patches of adding SANITIZE=leak > annotations to various tests, let's focus on the test mode itself > here and not overly distracting ourselves with whatever other > regressions on "seen" those annotations might cause, I can submit > those annotations later. > > * As noted in the updated commit message I didn't end up going with > Jeff King's suggestion of supporting LSAN_OPTIONS directly, and > fixing the "fd" the tests write to. All of those things can be > extended or fixed later. OK, I think we should proceed with this series/approach, then. The question of friction when CI fails is an open one, but we won't know until we have more data. So let's see what happens. :) The patches themselves look fine to me, though I had a few nits on the third commit message. -Peff
