On Mon, Sep 06 2021, Han-Wen Nienhuys via GitGitGadget wrote: > From: Han-Wen Nienhuys <hanwen@xxxxxxxxxx> > [...] > - puts(reflog_msg[i]); > + puts(reflog_msg[i]); /* XXX - this puts a > + newline. Did we put two > + newlines beforehand? */ I recently added some tests for show-branch, see the tip of ab/show-branch-tests. This seems like it would be clearer to both you & reviewers if we first checked & test_cmp'd the reflog behavior of "git show-branch" in some "here's how it works now test", then made whatever non-changes to the format done here. Presumably this newline mystery would become clear once we'd have coverage of its reflog codepaths.
