This re-roll should address all the comments on the v1, in particular
all of the changes that removed in-tree unused functions that are
documented in our manpages were ejected. This series is now only
removals of code that should always have been in-tree-only.
The minor change in 4/7 is new, and so is 5/7.
Ævar Arnfjörð Bjarmason (7):
git-sh-setup: remove unused git_pager() function
git-sh-setup: remove unused sane_egrep() function
git-sh-setup: move peel_committish() function to git-subtree.sh
git-sh-setup: clear_local_git_env() function to git-submodule.sh
git-sh-setup: remove unused "pull with rebase" message
git-bisect: remove unused SHA-1 $x40 shell variable
test-lib: remove unused $_x40 and $_z40 variables
contrib/subtree/git-subtree.sh | 12 +++++++++
git-bisect.sh | 2 --
git-sh-setup.sh | 45 ----------------------------------
git-submodule.sh | 7 +-----
t/t7006-pager.sh | 13 ----------
t/test-lib.sh | 6 ++---
6 files changed, 15 insertions(+), 70 deletions(-)
Range-diff against v1:
1: 2e3ed8061d5 < -: ----------- git-sh-setup: remove unused set_reflog_action() function
2: 7d3ea928099 < -: ----------- git-sh-setup: remove unused git_editor() function
3: 73e540896fc ! 1: 8eb1dfbff5d git-sh-setup: remove unused git_pager() function
@@ Metadata
## Commit message ##
git-sh-setup: remove unused git_pager() function
- Remove the git_editor() function last referenced by non-test code code
- in 49eb8d39c78 (Remove contrib/examples/*, 2018-03-25).
+ Remove the git_pager() function last referenced by non-test code in
+ 49eb8d39c78 (Remove contrib/examples/*, 2018-03-25).
We can also remove the test for this added in 995bc22d7f8 (pager: move
pager-specific setup into the build, 2016-08-04), the test that
@@ Commit message
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx>
## git-sh-setup.sh ##
-@@ git-sh-setup.sh: $LONG_USAGE")"
- esac
- fi
+@@ git-sh-setup.sh: git_editor() {
+ eval "$GIT_EDITOR" '"$@"'
+ }
-git_pager() {
- if test -t 1
4: 73f0676db7a = 2: e7f3115797c git-sh-setup: remove unused sane_egrep() function
5: dc4dd7d1399 < -: ----------- git-sh-setup: remove unused require_work_tree_exists() function
6: d2d65f3d77f < -: ----------- git-sh-setup: move create_virtual_base() to mergetools/p4merge
7: a3047b93f7d = 3: d92e880fcfa git-sh-setup: move peel_committish() function to git-subtree.sh
-: ----------- > 4: 46c018aa860 git-sh-setup: clear_local_git_env() function to git-submodule.sh
-: ----------- > 5: 45c1369e958 git-sh-setup: remove unused "pull with rebase" message
8: 88dffac9088 = 6: bcae7884bb0 git-bisect: remove unused SHA-1 $x40 shell variable
9: 0fd1516af85 = 7: 479e94f22f4 test-lib: remove unused $_x40 and $_z40 variables
--
2.33.0.821.gfd4106eadbd
