Re: [PATCH v3 0/4] cache parent project's gitdir in submodules

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi, Emily

On Thu, Aug 19, 2021 at 5:10 PM Emily Shaffer <emilyshaffer@xxxxxxxxxx> wrote:
>
> Emily Shaffer (4):
>   t7400-submodule-basic: modernize inspect() helper
>   introduce submodule.superprojectGitDir record
>   submodule: record superproject gitdir during absorbgitdirs
>   submodule: record superproject gitdir during 'update'

I left a few comments on patches 2 and 3. They are mostly about things
we have already discussed on the Review Club, but I got the chance to
experiment with the code a bit more after that, and I thought it could
be helpful to provide these inline suggestions. Hope it helps, and
thanks for the series!

Thanks,
Matheus



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux