Hi, Emily On Thu, Aug 19, 2021 at 5:10 PM Emily Shaffer <emilyshaffer@xxxxxxxxxx> wrote: > > Emily Shaffer (4): > t7400-submodule-basic: modernize inspect() helper > introduce submodule.superprojectGitDir record > submodule: record superproject gitdir during absorbgitdirs > submodule: record superproject gitdir during 'update' I left a few comments on patches 2 and 3. They are mostly about things we have already discussed on the Review Club, but I got the chance to experiment with the code a bit more after that, and I thought it could be helpful to provide these inline suggestions. Hope it helps, and thanks for the series! Thanks, Matheus