On Thu, Sep 2, 2021 at 1:58 PM Junio C Hamano <gitster@xxxxxxxxx> wrote: > Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes: > > Ævar Arnfjörð Bjarmason (9): > > git-sh-setup: remove unused set_reflog_action() function > > git-sh-setup: remove unused git_editor() function > > git-sh-setup: remove unused git_pager() function > > git-sh-setup: remove unused sane_egrep() function > > git-sh-setup: remove unused require_work_tree_exists() function > > git-sh-setup: move create_virtual_base() to mergetools/p4merge > > git-sh-setup: move peel_committish() function to git-subtree.sh > > git-bisect: remove unused SHA-1 $x40 shell variable > > test-lib: remove unused $_x40 and $_z40 variables > > Was "unused" above decided based solely on the presence of in-tree > users? If that is the case, I do not think we want to take these > sh-setup changes. > > The implementation details of the remaining part of git-bisect.sh > and test-lib.sh are OK, of course, as that is truly our local > issue. The removal of sane_egrep() is also unlikely to cause issues, as it wasn't documented as a public API, and it seems similar to the git-bisect's implementation details you refer to, except for git-submodule. Dropping it now would avoid having to change it to `grep -E` as egrep gets obsoleted. In that line, git_pager() and peel_committish() aren't documented either; document or drop? Carlo
