On Sat, 8 Sep 2007, Junio C Hamano wrote: > Even though our convention is "zero return means good", it goes a > bit too far for matches_pack_name() to return 0 when it found > the pack is what the name refers to. This fixes that silly and > obvious interface bug. For something with a boolean return value I agree. Otherwise, for interfaces where a non zero return value means error, it is best to use a negative value (like -1) which has less of a positive connotation, and that wasn't done here either. Nicolas - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
