WARNING: this will break CI with seen when merged and unless the kwown pedantic issue still remaining from fsmonitor[0] is merged first (expected to come in a reroll) this series has a different subject than v1 and that is currently tracked as cb/ci-build-pedantic, but is a reroll (even if it discards all changes from v1) and was originally suggested by Phillip as an alternative. because of that, it might conflict with changes proposed by Ævar[2] but that are still not in "seen" AFAIK and merges cleanly otherwise. first patch was suggested[1] by Peff, so hopefully my commit message and his assumed SoB are still worth not mixing it with patch 2 (which has a slight different but related focus and touches the same files) but since it is no longer a single patch, lets go wild. patches 3 and 4 are optional and mostly for RFC, so that a solution to any possible issue that the retiring of USE_PARENS_AROUND_GETTEXT_N are addressed. Carlo Marcelo Arenas Belón (3): developer: enable pedantic by default developer: add an alternative script for detecting broken N_() developer: move detect-compiler out of the main directory Jeff King (1): developer: retire USE_PARENS_AROUND_GETTEXT_N support Makefile | 22 +----- config.mak.dev | 7 +- detect-compiler => devtools/detect-compiler | 0 .../find_accidentally_concat_i18n_strings.pl | 69 +++++++++++++++++++ gettext.h | 24 ------- git-compat-util.h | 4 -- 6 files changed, 74 insertions(+), 52 deletions(-) rename detect-compiler => devtools/detect-compiler (100%) create mode 100755 devtools/find_accidentally_concat_i18n_strings.pl [0] https://lore.kernel.org/git/20210809063004.73736-3-carenas@xxxxxxxxx/ [1] https://lore.kernel.org/git/YS7c3169x5Wk4PlA@xxxxxxxxxxxxxxxxxxxxxxx/ [2] https://lore.kernel.org/git/cover-v3-0.8-00000000000-20210831T132546Z-avarab@xxxxxxxxx/ -- 2.33.0.481.g26d3bed244
