On Tue, Aug 31, 2021 at 1:57 PM Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> wrote: > > On the other hand maybe we should just remove > USE_PARENS_AROUND_GETTEXT_N entirely, i.e. always use the parens. that would break pedantic in all versions of gcc since it is a GNU extension and is not valid in any C standard. (unlike the ones we are using with weather balloons and that are valid C99) the C standard says arrays can be initialized by a string literal (obviously with quotes) and allows only optional {} which would avoid the accidental concatenation that triggered this, but can't be used as an alternative. > It doesn't seem worth the effort to forever maintain this special case > and use CI resources etc. to catch what was effectively a one-off typo. under that argument, removing this safeguard might be also possible. Carlo