On Tue, Aug 31, 2021 at 03:42:52PM +0200, Ævar Arnfjörð Bjarmason wrote: > In the free_mailmap_entry() code added in 0925ce4d49 (Add map_user() > and clear_mailmap() to mailmap, 2009-02-08) the intent was clearly to > clear the "me" structure, but while we freed parts of the > mailmap_entry structure, we didn't free the structure itself. The same > goes for the "mailmap_info" structure. > > This brings us from 50 failures when running t4203-mailmap.sh to > 49. Not really progress as far as the number of failures is concerned, > but as far as I can tell this fixes all leaks in mailmap.c > itself. There's still users of it such as builtin/log.c that call > read_mailmap() without a clear_mailmap(), but that's on them. > > Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> > --- Thanks, the patch looks good to me. I agree with Eric that mentioning "leak failures" in the second paragraph would make it less confusing. :) -Peff
