On Fri, Aug 27, 2021 at 10:02:12AM +0200, Ævar Arnfjörð Bjarmason wrote:
> Range-diff against v2:
> 1: 8c649ce3b4 = 1: 306f14a0f7 tr2: remove NEEDSWORK comment for "non-procfs" implementations
> 2: 0150e3402a = 2: a999e016a9 tr2: clarify TRACE2_PROCESS_INFO_EXIT comment under Linux
> 3: 1d835d6767 = 3: 45769da953 tr2: stop leaking "thread_name" memory
> 4: 1aa0dbc394 ! 4: 946140691f tr2: fix memory leak & logic error in 2f732bf15e6
> @@ Metadata
> Author: Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx>
>
> ## Commit message ##
> - tr2: fix memory leak & logic error in 2f732bf15e6
> + tr2: leave the parent list empty upon failure & don't leak memory
I agree with Junio that the earlier subject line could be improved, but
the replacement is a little verbose for my taste. On the other hand, I'm
not sure how to simplify it without it becoming:
tr2: memory leaks and bug fixes
;-).
So I think that what you wrote here is perfectly good. This version
looks good to me, too.
Thanks,
Taylor
