Re: [RFC PATCH] reftable: fixup for broken __FUNCTION__ use

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Aug 27, 2021 at 8:01 AM Ævar Arnfjörð Bjarmason
<avarab@xxxxxxxxx> wrote:
>
> The use of the __FUNCTION__ macro is non-standard, in this case all
> we're doing with it is generating a prettier unique filename based on
> the name of the function that makes it, presumably to make ad-hoc
> debugging easier.
..
> It's smaller because it punts on the whole notion of adding the
> function name to the filename, as argued above I think __LINE__ should
> be sufficient here (and is probably already overkill). The only reason
> to add __FUNCTION__ or __LINE__ to the filename is presumably for
> one-off ad-hoc debugging.

It's there so it's easy to track down which tests forget to cleanup
after they run, and __LINE__ works for this as well.

-- 
Han-Wen Nienhuys - Google Munich
I work 80%. Don't expect answers from me on Fridays.
--

Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich

Registergericht und -nummer: Hamburg, HRB 86891

Sitz der Gesellschaft: Hamburg

Geschäftsführer: Paul Manicle, Halimah DeLaine Prado




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux