This is a review of Eric Sunshin's
<20210830072118.91921-1-sunshine@xxxxxxxxxxxxxx> series.
Side note:
I'm generally trying to see if just sending a "proposed vX" is
more productive for everyone than patch feedback effectively
describing it in prose. I don't mean for this thing to be picked
up as-is by Junio without the consent of the submitter, and don't
have any desire to "pick up" the series myself.
My review workflow is just applying the patches locally, fiddling
with them, so it seems like the most straightforward and helpful
thing to send the result of that local end-state, rather than
describing the changes I made in prose, and expect the original
submitter to reverse engineer that state if they're interested in
trying it out locally themselves.
I really like the end goal of
<20210830072118.91921-1-sunshine@xxxxxxxxxxxxxx> series, but this
seems like a more straightforward way to get to that goal.
I.e. the original 1/3 and 2/3 starts out by making the tests
whitespace-independent. If we just skip that 1/3, and then in 3/3
tweak the relevant failing tests for the code change we won't even
need a new test, all the existing tests previously made
whitespace-independent in 1/3 will assert this new behavior.
Eric Sunshine (2):
t3303/t9301: make `notes` tests less brittle
notes: don't indent empty lines
notes.c | 2 +-
t/t3301-notes.sh | 28 ++++++++++++++--------------
t/t3303-notes-subtrees.sh | 13 ++++++++-----
t/t9301-fast-import-notes.sh | 36 +++++++++++++++++++-----------------
4 files changed, 42 insertions(+), 37 deletions(-)
Range-diff against v1:
1: d2915b20aee < -: ----------- t3301: tolerate minor notes-related presentation changes
2: 478d8b8d104 ! 1: 5a1ddd30859 t3303/t9301: make `notes` tests less brittle
@@ Commit message
desired information in a stable machine-consumable format.
Signed-off-by: Eric Sunshine <sunshine@xxxxxxxxxxxxxx>
+ Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx>
## t/t3303-notes-subtrees.sh ##
@@ t/t3303-notes-subtrees.sh: INPUT_END
3: 56d05862a67 < -: ----------- notes: don't indent empty lines
-: ----------- > 2: 4b546b83fd7 notes: don't indent empty lines
--
2.33.0.737.g0eefde7d76
