Jeff King <peff@xxxxxxxx> writes: >> - if (ignore_case) >> - return strcasecmp(e1->key, key ? key : e2->key); >> - else >> - return strcmp(e1->key, key ? key : e2->key); >> + return fspathcmp(e1->key, key ? key : e2->key); >> } >> >> static struct test_entry *alloc_test_entry(unsigned int hash, > > Maybe also: > > diff --git a/dir.c b/dir.c > index 03c4d21267..ee46290cbb 100644 > --- a/dir.c > +++ b/dir.c > @@ -669,9 +669,7 @@ int pl_hashmap_cmp(const void *unused_cmp_data, > ? ee1->patternlen > : ee2->patternlen; > > - if (ignore_case) > - return strncasecmp(ee1->pattern, ee2->pattern, min_len); > - return strncmp(ee1->pattern, ee2->pattern, min_len); > + return fspathncmp(ee1->pattern, ee2->pattern, min_len); > } > > static char *dup_and_filter_pattern(const char *pattern) > > This is fun. :) Yes. So we found three of them in the existing code. A Coccinelle rule may be an overkill, I guess.
