Hi Miriam, On Fri, 20 Aug 2021, Miriam Rubio wrote: > These patches correspond to a fourth part of patch series > of Outreachy project "Finish converting `git bisect` from shell to C" > started by Pranit Bauva and Tanushree Tumane > (https://public-inbox.org/git/pull.117.git.gitgitgadget@xxxxxxxxx) and > continued by me. > > This fourth part is formed by reimplementations of some `git bisect` > subcommands, addition of tests and removal of some temporary subcommands. > > These patch series emails were generated from: > https://gitlab.com/mirucam/git/commits/git-bisect-work-part4-v5. Apart from the stdout redirection in 5/6, the patches look really stable to me. Thanks, Dscho > > I would like to thank Johannes Schindelin, Bagas Sanjaya and > Christian Couder for reviewing this patch series. > > Specific changes > ---------------- > [1/6] t6030-bisect-porcelain: add tests to control bisect run exit cases > * Add evaluation of error code 255 in test 'bisect run fails with exit > code equals or greater than 128'. > * Remove test with error code smaller than 0. > --- > > [4/6] bisect--helper: reimplement `bisect_visualize()`shell function in C > * Use strvec_push() instead of strvec_pushl(). > --- > > [5/6] bisect--helper: reimplement `bisect_run` shell function in C > * Add error message. > * Remove exit variable. > * Write contents of bisect_state() in BISECT_RUN file and show to user. > --- > > Miriam Rubio (3): > t6030-bisect-porcelain: add tests to control bisect run exit cases > t6030-bisect-porcelain: add test for bisect visualize > bisect--helper: retire `--bisect-next-check` subcommand > > Pranit Bauva (2): > run-command: make `exists_in_PATH()` non-static > bisect--helper: reimplement `bisect_visualize()`shell function in C > > Tanushree Tumane (1): > bisect--helper: reimplement `bisect_run` shell function in C > > builtin/bisect--helper.c | 157 ++++++++++++++++++++++++++++++++++-- > git-bisect.sh | 87 +------------------- > run-command.c | 2 +- > run-command.h | 12 +++ > t/t6030-bisect-porcelain.sh | 18 +++++ > 5 files changed, 182 insertions(+), 94 deletions(-) > > -- > 2.29.2 > >
