On Mon, Aug 23, 2021 at 09:47:28PM +0000, Marvin Häuser wrote: > On 23/08/2021 20:27, Jeff King wrote: > > But either that should go into its own patch, or the commit message > > should be modified to explain that it is covering not just > > in-reply-to/references, but we think this fixes all similar variables. > > Fixed, opted for latter [1]. Left a comment in github; dropping the "Subject" move would be also needed to fully do that (the fix doesn't need it) > > - note the weird behavior I found with --in-reply-to; this is > > something we might want to address at the same time > > I think this case must error? The definition of the "--in-reply-to" does not > declare it as a default, so it must be enforced (and it is), but it's also > very unintuitive the file value is discarded. Who would decide the behaviour > spec? AFAIK, this is what the cryptic warning in the documentation[1] talks about. the "argument" being that most of the times that header is incorrect (because it was incorrectly set by format-patch) or it is meant to be wiped out to keep this patch together with the rest in the reroll. the warning was added with f693b7e9a5 (Improve doc for format-patch threading options., 2009-07-22), so throwing an error now might not be wise, but maybe a documentation update. Carlo [1] https://git-scm.com/docs/git-send-email#Documentation/git-send-email.txt---no-thread -------- >8 ---------- diff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt index 3db4eab4ba..76687d0574 100644 --- a/Documentation/git-send-email.txt +++ b/Documentation/git-send-email.txt @@ -385,10 +385,10 @@ default to --thread. It is up to the user to ensure that no In-Reply-To header already exists when 'git send-email' is asked to add it (especially note that 'git format-patch' can be configured to do the threading itself). -Failure to do so may not produce the expected result in the +Failure to do so will result in that header being reset, accordingly +to the options used and may not produce the expected result in the recipient's MUA. - Administering ~~~~~~~~~~~~~
