Hello, Sorry to come back after such a long time. I just resumed working on that series and would have a question about a review comment. Le mardi 6 juillet 2021, 21:56:38 CEST Ævar Arnfjörð Bjarmason a écrit : > On Fri, Jul 02 2021, Lénaïc Huard wrote: > > +#ifdef __APPLE__ > > + return 1; > > +#else > > + return 0; > > +#endif > > +} > > > I see this is partially a pre-existing thing in the file, but we have an > __APPLE__ already in cache.h. Perhaps define a iLAUNCHCTL_AVAILABLE > there. See e.g. 62e5ee81a39 (read-cache.c: remove #ifdef NO_PTHREADS, > 2018-11-03). Is the suggestion to replace +#ifdef __APPLE__ + return 1; +#else + return 0; +#endif +} by + return IS_LAUNCHCTL_AVAILABLE; and to add #ifdef __APPLE__ #define IS_LAUNCHCTL_AVAILABLE 1 #else #define IS_LAUNCHCTL_AVAILABLE 0 #endif somewhere else like at the top of builtin/gc.c ? Also, do we agree this shouldn’t be defined in cache.h ? I’m a little bit confused. Kind regards, Lénaïc.
