On Mon, 2021-08-23 at 12:06 -0400, Jeff King wrote: > On Mon, Aug 23, 2021 at 11:40:49AM +0200, Johannes Berg wrote: > > > If using --object-dir to point into a repo while the current > > working dir is outside, such as > > > > git init /repo > > git -C /repo ... # add some objects > > cd /non-repo > > git multi-pack-index --object-dir /repo/.git/objects/ write > > > > the binary will segfault trying to access the object-dir via > > the repo it found, but that's not fully initialized. Fix it > > to use the object_dir properly to clean up the *.rev files, > > this avoids the crash and cleans up the *.rev files for the > > now rewritten multi-pack-index properly. > > I'm not entirely convinced that writing a midx when not "inside" a repo > is something that we want to support. But if we do, then... Seemed like that was the point of --object-dir? johannes
