On Mon, 2021-08-23 at 09:19 -0400, Derrick Stolee wrote: > > We just add subshells this way: > > test_expect_success 'test name' ' > prep_step && > ( > # now in a subshell > cd wherever && > do things > # don't need to cd again > ) && > continue test > ' Sure. I know how to do subshells :) My point was that inside the subshell you cannot do test_path_is_file and similar, because the subshell didn't import the libs. > > More importantly, how do you feel about the "cd /"? > > > > The tests are always run in a place where there's a parent git folder > > (even if it's git itself), so you cannot reproduce the segfault in a > > test without the "cd /", though I guess "cd /tmp" would also work or > > something, but "cd /" felt pretty safe, hopefully not many people have > > "/.git" on their system. > > Don't leave the directory your test is set up to run in. I was specifically asking Junio ;-) But realistically, if this is the requirement you want to impose, then you _cannot_ test for the segfault within git's test suite. Your loss. johannes
