On 20/08/2021 07:09, Junio C Hamano wrote: > Junio C Hamano <gitster@xxxxxxxxx> writes: > >> * hn/reftable (2021-08-16) 25 commits >> - t1404: annotate test cases with REFFILES >> ... >> - hash.h: provide constants for the hash IDs >> >> The "reftable" backend for the refs API. > > As discussed in the thread that leads to [*1*], this topic has been > blocked by the "clean-up errno use in the refs subsystem" topic for > too long. I think it deserves to have its own chance to be looked > at by more eyes. > > I've reverted the three topics around "errno" out of 'next', while > rebasing them into a single strand of pearls, and queued them near > the tip of 'seen'. The hn/reftable topic is merged into 'seen' > earlier then these "errno" topics. Just a gentle reminder that this topic tickles my 'static-check.pl' script, like so: $ diff nsc ssc ... 88a91,98 > reftable/generic.o - reftable_table_seek_log > reftable/merged.o - reftable_merged_table_hash_id > reftable/merged.o - reftable_merged_table_min_update_index > reftable/merged.o - reftable_merged_table_seek_log_at > reftable/publicbasics.o - reftable_set_alloc > reftable/reader.o - reader_seek > reftable/reader.o - reftable_reader_seek_log_at > reftable/stack.o - reftable_stack_auto_compact ... $ Which is to say, all of the above symbols are defined (and called) in the '.c' file corresponding to the given object file, but not called anywhere outside that file. I have not even looked at those functions, but (with the possible exception of reftable_set_alloc()) they don't strike me as 'public API functions'. So, maybe they should be marked as 'static'? ATB, Ramsay Jones
