On 8/20/2021 6:08 AM, Patrick Steinhardt wrote: > Refactor `fetch_refs()` code to make it more extendable by explicitly > handling error cases. The refactored code should behave the same. It took unrolling this diff to understand that this code behaves the same, and it's because of the previous code using "if (!ret) return 0;" to handle two possible ways that 'ret' could become zero. I agree that the new code makes it clear that we can leave early after a successful call to check_exist_and_connected() and again after a successful call to transport_fetch_refs(). Thanks -Stolee
