On Fri, Sep 07, 2007 at 01:01:48AM -0400, Shawn O. Pearce wrote: > "Dmitry V. Levin" <ldv@xxxxxxxxxxxx> wrote: > > > "Dmitry V. Levin" <ldv@xxxxxxxxxxxx> wrote: > > > > On GNU/Linux, libdir is used to mean "/usr/lib or /usr/lib64" > > > > depending on architecture. Different libdir meaning breaks > > > > idiomatic expressions like rpm specfile "make libdir=%_libdir". > > > > The idea is that git-gui's libdir is not a traditional arch-dependent > > libdir's subdirectory, but rather arch-independent datadir's subdirectory. > > That is, I see no reason to call it libdir even in standalone project. > > Call it datadir then? I see you point, and now agree with you. I'm not sure that "datadir" is better choice than current "libdir". First, from git-gui point of view, files placed in git-gui/lib/ are rather library files than data files. Second, if top-level makefile will define "datadir", original issue will raise again. That's why I suggested to add some git-gui specific component to git-gui's libdir variable name. -- ldv
Attachment:
pgpwp4L8xgDbS.pgp
Description: PGP signature
