Hi Eric, On Tue, 17 Aug 2021, Eric Sunshine wrote: > On Tue, Aug 17, 2021 at 5:29 PM Johannes Schindelin > <Johannes.Schindelin@xxxxxx> wrote: > > On Tue, 17 Aug 2021, Bagas Sanjaya wrote: > > > diff --git a/Makefile b/Makefile > > > @@ -3093,6 +3093,9 @@ endif > > > +install-strip: all strip > > > > Would those `all` and `strip` targets interfere with one another if `make > > -j2` was called? If not, wouldn't it be sufficient to let `install-strip` > > depend on `strip` alone? > > A more pertinent question, perhaps, is why would we need > `install-strip` at all? What benefit does it provide over simply > typing `make strip install`? That would require an order-only prerequisite (see https://www.gnu.org/software/make/manual/html_node/Prerequisite-Types.html) for `make -j2 strip install` to work correctly, i.e. something like this: -- snip -- diff --git a/Makefile b/Makefile index 2d5c822f7a8..9987f3b2c13 100644 --- a/Makefile +++ b/Makefile @@ -2990,7 +2990,7 @@ profile-install: profile profile-fast-install: profile-fast $(MAKE) install -install: all +install: all | strip $(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(bindir_SQ)' $(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(gitexec_instdir_SQ)' $(INSTALL) $(ALL_PROGRAMS) '$(DESTDIR_SQ)$(gitexec_instdir_SQ)' -- snap -- I am not quite certain that this is compatible with other `make` implementations we still might support (if there are any, I remember that we often have to rely on `gmake` because the native `make` does not understand our `Makefile`?), so that might need to be conditional on GNU Make. Ciao, Dscho
