On 8/17/2021 1:49 PM, SZEDER Gábor wrote:
> In a helper function in the 't1600-index.sh' test script the stderr
> of a 'git add' command is redirected to its stdout, but its stdout is
> not redirected anywhere. So apparently this redirection is
> unnecessary, remove it.
>
> Signed-off-by: SZEDER Gábor <szeder.dev@xxxxxxxxx>
> ---
> t/t1600-index.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/t/t1600-index.sh b/t/t1600-index.sh
> index c9b9e718b8..5d10cec67a 100755
> --- a/t/t1600-index.sh
> +++ b/t/t1600-index.sh
> @@ -79,7 +79,7 @@ test_index_version () {
> else
> unset GIT_INDEX_VERSION
> fi &&
> - git add a 2>&1 &&
> + git add a &&
> echo $EXPECTED_OUTPUT_VERSION >expect &&
> test-tool index-version <.git/index >actual &&
> test_cmp expect actual
Since here we have a 'test_cmp expect actual', perhaps the
actual mistake is that the line isn't
git add a 2>&1 >actual &&
What do you think about that?
Thanks,
-Stolee
