On Tue, Aug 17, 2021 at 11:03 AM Bagas Sanjaya <bagasdotme@xxxxxxxxx> wrote: > > On 17/08/21 15.14, Miriam Rubio wrote: > > > +test_expect_success 'bisect run fails with exit code equals or greater than 128' ' > > + write_script test_script.sh <<-\EOF && > > + exit 128 >/dev/null > > + EOF > > + test_must_fail git bisect run ./test_script.sh > my_bisect_log.txt > > +' > > This only checks for exit code equals to 128. You should also check for > exit code greater than 128, for example 255. > > > + > > +test_expect_success 'bisect run fails with exit code smaller than 0' ' > > + write_script test_script.sh <<-\EOF && > > + exit -1 >/dev/null > > + EOF > > + test_must_fail git bisect run ./test_script.sh > my_bisect_log.txt > > +' > > This test looks OK, using -1 as representative of negative exit code. > However, wording of test name can also be 'bisect run fails with > negative exit code'. Actually I am not sure that it makes sense to test an exit code smaller than 0, as POSIX exit codes are between 0 and 255 (included). For example: $ bash -c 'exit -1'; echo $? 255 $ dash -c 'exit -1'; echo $? dash: 1: exit: Illegal number: -1 2
