Re: git format-patch -s enhancement

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 16/08/21 06.07, jim.cromie@xxxxxxxxx wrote:
hi all

git format-patch -s is sub-optimal :
it appends the SoB,
which falls after the snips
---
changelog ...
that the commit message may contain


So it misfires on any maintainer scripts
expecting the SoB above the 1st snip.

The workaround is manual SoBs above any snips.

I note this in -s doc,

            Add a Signed-off-by trailer to the commit message, using
the committer identity of yourself.
            See the signoff option in git-commit(1) for more information.

"trailer" is really "document current working behavior"
(normative docu-speak, so to speak;)

Ideal behavior is to find 1st in-body  --- snip
and insert there


It seems like you don't tell us what snip means. Can you describe your environment and reproduction steps so that I can reproduce this issue?

And next time you can use `git bugreport`.

--
An old man doll... just what I always wanted! - Clara



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux