> > +static struct string_list added_submodule_odb_paths = STRING_LIST_INIT_NODUP; > > + > > I see 2/7 allows callers to add paths for submodule odb to this > list. Yes, and as you said below, add_submodule_odb() has been modified to add to this list too. > The "pretend as if objects in submodule odb are locally available", > even though it may have been useful, was an ugly hack invented > before we started adding the "access more than one repository at the > time with the 'repo' arg" extended API. It is pleasing to see this > step shows an approach to incrementally migrate the users of the > hack. Thanks.